fix(anthropic): preserve routed response model metadata - #1121
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
Thank you — your diagnosis here was correct and independent, and I want that on the record. The fix for #1117 is landing as #1138. For the implementation I built on #1122, which covers native passthrough response metadata and alias-collision cases that this PR does not — but you identified the same root cause (the final-route rewrite of Duplicate work is a cost you paid, not one you caused; two people finding the same real defect independently is a signal the defect was worth fixing. Leaving this PR open for you to close or continue. |
|
Closing — the defect you diagnosed is fixed on #1117 is resolved by #1138 (merge commit Closing as superseded rather than rejected. Duplicate work is a cost you paid, not one you caused; two people independently finding the same real defect is a signal it was worth fixing. Verified: 9,593 pass / 0 fail on the merged tree; CI green on the exact |
Summary
Closes #1117
Verification
bun run typecheck- passed on latestdev(bbd82e73).bun test tests/anthropic-response-model.test.ts tests/openai-api-virtual-models.test.ts tests/server-combo-failover-e2e.test.ts tests/images/loop.test.ts tests/web-search.test.ts tests/codex-catalog.test.ts tests/codex-catalog-restore.test.ts- 291 passed, 0 failed.bun run privacy:scan- passed.Checklist